Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "basic" system tests of lobster-json #153

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

phiwuu
Copy link
Member

@phiwuu phiwuu commented Dec 11, 2024

Revert gitignore for expected-output:
All files in any folder called expected-output inside tests-system are exempted from all gitignore rules.

Improve readability of assertion messages for system tests:
If there is a difference between the expected and actual output of either stdout or stderr, then these values are fully printed. This helps developers to spot errors faster.

Migrate "basic" system tests of lobster-json:
Migrate the "basic" system test so that they can be executed with the run_tool_tests.py tool.

Write requirements for these tests.

run_tool_tests.py now deletes *.lobster files that were generated during test execution.

@phiwuu phiwuu requested a review from a team as a code owner December 11, 2024 00:03
@phiwuu phiwuu added the internal Affects the CI, tests or refactorings only, not relevant to the end-user label Dec 11, 2024
@phiwuu phiwuu self-assigned this Dec 11, 2024
@phiwuu phiwuu changed the title Internal/lobster json tests Migrate "basic" system tests of lobster-json Dec 11, 2024
@phiwuu phiwuu changed the title Migrate "basic" system tests of lobster-json Migrate "basic" system tests of lobster-json Dec 11, 2024
@phiwuu phiwuu force-pushed the internal/lobster-json-tests branch 6 times, most recently from d9b7bd6 to aa2a9f0 Compare December 11, 2024 00:43
@phiwuu phiwuu enabled auto-merge (squash) December 11, 2024 00:49
All files in any folder called `expected-output` inside `tests-system`
are exempted from all gitignore rules.

Improve readability of assertion messages for system tests:
If there is a difference between the expected and actual output
of either stdout or stderr, then these values are fully printed.
This helps developers to spot errors faster.
Migrate the "basic" system test so that they can be executed with
the `run_tool_tests.py` tool.

Write requirements for these tests.

`run_tool_tests.py` now deletes *.lobster files that were generated
during test execution.
@phiwuu phiwuu force-pushed the internal/lobster-json-tests branch from aa2a9f0 to e47a1b6 Compare December 11, 2024 14:05
@phiwuu phiwuu merged commit b6f3095 into main Dec 11, 2024
23 checks passed
@phiwuu phiwuu deleted the internal/lobster-json-tests branch December 11, 2024 14:09
phiwuu added a commit that referenced this pull request Dec 12, 2024
The file
`tests-system/lobster-trlc/rbt-output-file/default-scenario/expected-output/.gitignore`
has become obsolete. All exemptions for all files under `expected-output` are
specified through `tests-system/.gitignore` since pull request #153.
phiwuu added a commit that referenced this pull request Dec 12, 2024
The file
`tests-system/lobster-trlc/rbt-output-file/default-scenario/expected-output/.gitignore`
has become obsolete. All exemptions for all files under
`expected-output` are specified through `tests-system/.gitignore` since
pull request
#153.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Affects the CI, tests or refactorings only, not relevant to the end-user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants